-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): TorchRL - MAML integration #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
XuehaiPan
previously approved these changes
Aug 11, 2022
Benjamin-eecs
dismissed
XuehaiPan’s stale review
August 11, 2022 14:57
torchrl example is not working
Yes it is on train, just needs better sync on test wrt the seed setting. (At least on my machine, let me update the plot). Results aren't quite different tbh, and we're still far from significant learning improvement in the original version (the error bars are hugely overlapping) |
XuehaiPan
previously approved these changes
Sep 1, 2022
XuehaiPan
approved these changes
Sep 1, 2022
Benjamin-eecs
approved these changes
Sep 1, 2022
XuehaiPan
changed the title
TorchRL - MAML integration
feat(examples): TorchRL - MAML integration
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brand-new version of the old PR
One can test this by running
I have added the
--parallel
flag, to allow users to have more than one environment used.It can run on cuda if devices are present.
FYI: This should run on latest
main
in torchrl