Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): TorchRL - MAML integration #12

Merged
merged 66 commits into from
Sep 1, 2022
Merged

feat(examples): TorchRL - MAML integration #12

merged 66 commits into from
Sep 1, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 10, 2022

Brand-new version of the old PR

One can test this by running

python maml_torchrl.py --parallel --seed 1

I have added the --parallel flag, to allow users to have more than one environment used.

It can run on cuda if devices are present.

FYI: This should run on latest main in torchrl

@vmoens vmoens mentioned this pull request May 10, 2022
@vmoens vmoens requested a review from Benjamin-eecs May 10, 2022 15:13
@Benjamin-eecs Benjamin-eecs added the enhancement New feature or request label May 11, 2022
@Benjamin-eecs Benjamin-eecs linked an issue Jul 19, 2022 that may be closed by this pull request
1 task
XuehaiPan
XuehaiPan previously approved these changes Aug 11, 2022
@Benjamin-eecs Benjamin-eecs dismissed XuehaiPan’s stale review August 11, 2022 14:57

torchrl example is not working

@vmoens
Copy link
Contributor Author

vmoens commented Aug 11, 2022

Yes it is on train, just needs better sync on test wrt the seed setting. (At least on my machine, let me update the plot).

Results aren't quite different tbh, and we're still far from significant learning improvement in the original version (the error bars are hugely overlapping)
I'm happy to do some more hyperparameter optimisation to match the other results better.

XuehaiPan
XuehaiPan previously approved these changes Sep 1, 2022
@XuehaiPan XuehaiPan changed the title TorchRL - MAML integration feat(examples): TorchRL - MAML integration Sep 1, 2022
@XuehaiPan XuehaiPan merged commit 0bc346c into main Sep 1, 2022
@XuehaiPan XuehaiPan deleted the torchrl_new branch September 1, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example / tutorial Something related to examples or tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add TorchRL examples
3 participants